Export type for return of getCapabilities()#3266
Merged
Conversation
Renamed because it clashes with ICapabilities from embedded
Renamed because it clashes with ICapabilities from embedded
hughns
force-pushed
the
hughns/expose-capabilities-type
branch
from
9a6a5ec to
5ee3a4b
Compare
…matrix-org/matrix-js-sdk into hughns/expose-capabilities-type
3 tasks
t3chguy
approved these changes
Apr 6, 2023
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
If we're renaming it can we drop the I prefix, we stopped doing that a while ago
t3chguy
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed because it clashes with ICapabilities from embedded. I would happily take alternative naming suggestions.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.